Re: Review Request 65784: Added validation of QuotaRequest.

2018-10-15 Thread Benjamin Mahler
> On May 1, 2018, 11:40 p.m., Meng Zhu wrote: > > src/master/quota.cpp > > Lines 199-200 (patched) > > > > > > Add `AllocationInfo` and `SharedInfo` check as well? > > Meng Zhu wrote: > Now we can use `isScalarQ

Re: Review Request 65784: Added validation of QuotaRequest.

2018-06-28 Thread Meng Zhu
> On May 1, 2018, 4:40 p.m., Meng Zhu wrote: > > src/master/quota.cpp > > Lines 199-200 (patched) > > > > > > Add `AllocationInfo` and `SharedInfo` check as well? Now we can use `isScalarQuantity()` for this https:

Re: Review Request 65784: Added validation of QuotaRequest.

2018-05-01 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65784/#review202244 --- Fix it, then Ship it! src/master/quota.cpp Lines 199-200 (patc

Re: Review Request 65784: Added validation of QuotaRequest.

2018-03-18 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65784/#review199392 --- Ship it! Ship It! - Meng Zhu On Feb. 23, 2018, 2:43 p.m., Be

Review Request 65784: Added validation of QuotaRequest.

2018-02-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65784/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos Descri