Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review200172 --- Ship it! Ship It! - Gilbert Song On March 28, 2018, 5:07 p.m

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review200166 --- PASS: Mesos patch 65876 was successfully built and tested. Review

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review200164 --- Patch looks great! Reviews applied: [65855, 65856, 65876] Passed

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/ --- (Updated March 29, 2018, 12:07 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-28 Thread Chun-Hung Hsiao
> On March 22, 2018, 11:08 p.m., Gilbert Song wrote: > > As we discussed, the motivation to remove the default values is to make it explicit at the call site to improve readability. - Chun-Hung --- This is an automatically generated e-

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review199817 --- src/uri/fetchers/docker.cpp Line 96 (original), 96 (patched)

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review198554 --- Patch looks great! Reviews applied: [65855, 65856, 65876] Passed

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-02 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review198553 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-02 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/ --- (Updated March 2, 2018, 7:20 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review198517 --- Patch looks great! Reviews applied: [65855, 65856, 65876] Passed

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-01 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review198511 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-01 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8620 https://issues.