Re: Review Request 65954: Add a gauge for how long agent recovery takes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65954/#review199195 --- Fix it, then Ship it! Nit: When you commit, can you s/Add/Adde

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

> On March 9, 2018, 6:53 p.m., James Peach wrote: > > src/slave/metrics.hpp > > Lines 45 (patched) > > > > > > This doesn't need to be atomic. The reader will just read either the > > old or new values and it doesn't

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65954/ --- (Updated March 14, 2018, 4:06 p.m.) Review request for mesos, Gilbert Song, Gre

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

> On March 9, 2018, 6:53 p.m., James Peach wrote: > > src/slave/metrics.cpp > > Lines 259 (patched) > > > > > > I don't know that I like the idea of a metric that is absent and then > > present. I'd prefer that we j

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

> On March 9, 2018, 6:54 p.m., James Peach wrote: > > This also needs to be documented in `docs/monitoring.md`. Will do in a follow up patch after receiving shipit. - Zhitao --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65954/#review198954 --- This also needs to be documented in `docs/monitoring.md`. - James

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65954/#review198952 --- src/slave/metrics.hpp Lines 45 (patched)

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65954/ --- (Updated March 7, 2018, 11:20 p.m.) Review request for mesos, Gilbert Song, Gre

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65954/#review198813 --- Patch looks great! Reviews applied: [65954] Passed command: expo

Re: Review Request 65954: Add a gauge for how long agent recovery takes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65954/#review198799 --- PASS: Mesos patch 65954 was successfully built and tested. Review

Review Request 65954: Add a gauge for how long agent recovery takes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65954/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-8609 http