Re: Review Request 66034: Remount several proc filesystem entries as read-only.

2018-03-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/#review199366 --- Ship it! Ship It! - Jie Yu On March 15, 2018, 6:24 p.m., Jas

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

2018-03-15 Thread Jason Lai
> On March 15, 2018, 6:30 p.m., Zhitao Li wrote: > > I feel that the complexity of this code justifies better user doc, possibly > > when we create a new isolator for this? > > > > Also, how much of each mount should be allow to reconfigure? Should this > > behavior be dictated for every user

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

2018-03-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/#review199281 --- I feel that the complexity of this code justifies better user doc,

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

2018-03-15 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/ --- (Updated March 15, 2018, 6:24 p.m.) Review request for mesos, Eric Chung, Gilbe

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

2018-03-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/#review199068 --- Patch looks great! Reviews applied: [66034] Passed command: expo

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

2018-03-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/#review199057 --- PASS: Mesos patch 66034 was successfully built and tested. Review

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

2018-03-12 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/ --- (Updated March 13, 2018, 1:29 a.m.) Review request for mesos, Eric Chung, Gilbe

Review Request 66034: Remount several proc filesystem entries as read-only.

2018-03-12 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/ --- Review request for mesos, Eric Chung, Gilbert Song, Ian Downes, Jie Yu, James Pe