Re: Review Request 66175: Added isolator checks for namespaces support.

2018-03-20 Thread James Peach
> On March 20, 2018, 8:18 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > > Lines 91-94 (patched) > > > > > > Just one question: under what scenarios does `ns

Re: Review Request 66175: Added isolator checks for namespaces support.

2018-03-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66175/#review199574 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 66175: Added isolator checks for namespaces support.

2018-03-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66175/#review199573 --- Patch looks great! Reviews applied: [66175] Passed command: expo

Re: Review Request 66175: Added isolator checks for namespaces support.

2018-03-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66175/#review199563 --- PASS: Mesos patch 66175 was successfully built and tested. Review

Review Request 66175: Added isolator checks for namespaces support.

2018-03-20 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66175/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6555 https://issues.apache