Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 3:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function f

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 3:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function f

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 3:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function f

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 3:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function f

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 3:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function f

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201785 --- src/master/master.cpp Line 4512 (original), 4515-4527 (patched) <

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/ --- (Updated April 23, 2018, 1:07 p.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/ --- (Updated April 20, 2018, 4:15 p.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 19, 2018, 9:58 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515 (patched) > > > > > > Nit: there's an extra space after the comma. after the colon I mean :) - Greg

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201570 --- src/master/master.cpp Line 4512 (original), 4515 (patched)

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201561 --- src/master/master.cpp Lines 4511 (patched)

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/ --- (Updated April 17, 2018, 3:53 p.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201351 --- Fix it, then Ship it! src/master/master.cpp Lines 4510 (patche

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 17, 2018, 12:04 p.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 4525 (patched) > > > > > > I'm not sure about this. Would `REASON_TASK_INVALID` be more > > appropriate? I honest don't t

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201346 --- src/master/master.cpp Lines 4519-4522 (original), 4543-4546 (patc

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201342 --- src/master/master.cpp Lines 4525 (patched)

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/ --- (Updated April 17, 2018, 10 a.m.) Review request for mesos, Chun-Hung Hsiao and