Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer.

2018-05-11 Thread Andrei Budnik
> On May 10, 2018, 9:23 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Lines 488-502 (original), 493-512 (patched) > > > > > > I'm wondering if, instead of also adding a callback for this in >

Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer.

2018-05-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review202944 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer.

2018-05-11 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review202941 --- Bad patch! Reviews applied: [9, 8] Failed command: pytho

Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer.

2018-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review202868 --- src/slave/containerizer/composing.cpp Lines 488-502 (original), 4

Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer.

2018-05-09 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review202819 --- Ship it! src/slave/containerizer/composing.cpp Line 358 (origi

Review Request 66669: Added clean up of `containers_` map in composing containerizer. (WIP)

2018-04-17 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang