Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204276 --- Ship it! Ship It! - Joseph Wu On June 4, 2018, 12:11 p.m., J

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204274 --- PASS: Mesos patch 67066 was successfully built and tested. Review

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated June 4, 2018, 7:11 p.m.) Review request for mesos, Akash Gupta, Andrew

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204222 --- Patch looks great! Reviews applied: [67118, 67064, 67065, 67066]

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204209 --- PASS: Mesos patch 67066 was successfully built and tested. Review

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated June 1, 2018, 9:58 p.m.) Review request for mesos, Akash Gupta, Andrew

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204160 --- Patch looks great! Reviews applied: [67118, 67064, 67065, 67066]

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204085 --- Ship it! - Eric Mumau On May 30, 2018, 8:30 p.m., John Kordic

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204084 --- src/tests/fetcher_tests.cpp Line 1015 (original)

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204083 --- PASS: Mesos patch 67066 was successfully built and tested. Review

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 30, 2018, 8:30 p.m.) Review request for mesos, Akash Gupta, Andrew

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

> On May 29, 2018, 1:38 p.m., John Kordich wrote: > > I'm not sure why review bot is failing for Linux. Will investigate. Seems > > to build just fine for me. You probably need to add any new stout headers to the Makefile(s). The `distcheck` won't pick up headers automatically. - Joseph -

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204009 --- I'm not sure why review bot is failing for Linux. Will investigate

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review203847 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 25, 2018, 2:13 a.m.) Review request for mesos, Akash Gupta, Andrew

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review203713 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 23, 2018, 11:03 p.m.) Review request for mesos, Akash Gupta, Andre

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review203366 --- src/tests/fetcher_tests.cpp Lines 1023-1026 (original), 1013-1019

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review203157 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 15, 2018, 6:30 p.m.) Review request for mesos, Akash Gupta, Andrew

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review203083 --- PASS: Mesos patch 67066 was successfully built and tested. Review

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 14, 2018, 10:42 p.m.) Review request for mesos, Akash Gupta, Andre

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review203054 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 14, 2018, 5:13 p.m.) Review request for mesos, Akash Gupta, Andrew

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review202888 --- Bad patch! Reviews applied: [67066, 67065, 67064] Failed command

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review202867 --- FAIL: Failed to apply the dependent review: 67064. Failed command

Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Er