Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review204165 --- Patch looks great! Reviews applied: [67398, 67137] Passed

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review204117 --- PASS: Mesos patch 67137 was successfully built and tested.

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203883 --- src/slave/containerizer/mesos/launch.cpp Lines 1122 (patched)

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203810 --- Patch looks great! Reviews applied: [67137] Passed command:

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203760 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 24, 2018, 1:13 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203744 --- Patch looks great! Reviews applied: [67137] Passed command:

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203708 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203705 --- Fix it, then Ship it!

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 24, 2018, 12:25 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203641 --- Patch looks great! Reviews applied: [67137] Passed command:

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 22, 2018, 11:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 1053-1054 (patched) > > > > > > this is problematic? > > Jie Yu wrote: > At least the comment suggest

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 22, 2018, 11:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 1053-1054 (patched) > > > > > > this is problematic? At least the comment suggest something different - Jie

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203615 --- src/slave/containerizer/mesos/launch.cpp Lines 1053-1054

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203578 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018,

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203561 --- PASS: Mesos patch 67137 was successfully built and tested.

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 22, 2018, 12:44 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203426 --- src/slave/containerizer/mesos/launch.cpp Lines 484-485 (patched)

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203417 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203414 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 15, 2018, 8:28 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 1110-1113 (patched) > > > > > > Why not just `O_CLOEXEC` all the handles opened on Linux (so that you

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 18, 2018, 2:36 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203234 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203231 --- src/slave/containerizer/mesos/launch.cpp Lines 1040 (patched)

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203227 --- Patch looks great! Reviews applied: [67137] Passed command:

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203216 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 15, 2018, 8:28 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 481 (patched) > > > > > > This kind of logic will _never_ work on Windows, because the file > >

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 16, 2018, 1:56 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203190 --- Patch looks great! Reviews applied: [67136, 67137] Passed

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 15, 2018, 8:28 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 481 (patched) > > > > > > This kind of logic will _never_ work on Windows, because the file > >

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203154 --- src/slave/containerizer/mesos/launch.cpp Lines 481 (patched)

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203151 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- Review request for mesos, Gilbert Song, Jie Yu, and James Peach. Bugs: