Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-31 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/ --- (Updated May 31, 2018, 10:59 p.m.) Review request for mesos, Gaston Kleiman, Ji

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203773 --- Bad patch! Reviews applied: [67241] Failed command: python suppo

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203725 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/ --- (Updated May 23, 2018, 6:08 p.m.) Review request for mesos, Gaston Kleiman, Jie

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203706 --- Fix it, then Ship it! src/slave/containerizer/mesos/io/switchb

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203655 --- Patch looks great! Reviews applied: [67241] Passed command: expo

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203632 --- PASS: Mesos patch 67241 was successfully built and tested. Review

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-22 Thread Gilbert Song
> On May 21, 2018, 5:08 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 310-311 (patched) > > > > > > I'd print out some infomation that's relevant to this isolator for us > > to d

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/ --- (Updated May 22, 2018, 6:57 p.m.) Review request for mesos, Gaston Kleiman, Jie

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203592 --- Patch looks great! Reviews applied: [67241] Passed command: expo

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203547 --- PASS: Mesos patch 67241 was successfully built and tested. Review

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203545 --- src/slave/containerizer/mesos/isolators/volume/secret.cpp Lines 2

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203544 --- src/slave/containerizer/mesos/io/switchboard.cpp Lines 310-311 (p

Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

2018-05-21 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/ --- Review request for mesos, Gaston Kleiman, Jie Yu, Qian Zhang, and Vinod Kone. R