Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review205418 --- Patch looks great! Reviews applied: [67552, 67601] Passed

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-26 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review205412 --- PASS: Mesos patch 67601 was successfully built and tested.

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-26 Thread longfei niu
> On 六月 21, 2018, 6:52 p.m., Gilbert Song wrote: > > src/tests/slave_tests.cpp > > Lines 2413 (patched) > > > > > > Instead of to string.find(), I would prefer: > > > > ``` > >

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-26 Thread longfei niu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/ --- (Updated 六月 27, 2018, 3:03 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-21 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review205196 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 2413

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review204900 --- Patch looks great! Reviews applied: [67552, 67601] Passed

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review204890 --- PASS: Mesos patch 67601 was successfully built and tested.

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-15 Thread longfei niu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/ --- (Updated 六月 16, 2018, 1:20 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review204808 --- Fix it, then Ship it! LGTM! Thanks!

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review204802 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-14 Thread longfei niu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/ --- Review request for mesos and Gilbert Song. Summary (updated) -