Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-26 Thread Benjamin Bannier
> On June 18, 2018, 11:17 a.m., Benjamin Bannier wrote: > > 3rdparty/cmake/Findlibevent.cmake > > Lines 1 (patched) > > > > > > This file should be called `3rdparty/cmake/FindLIBEVENT.cmake` (package > > name all

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-25 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review205331 --- PASS: Mesos patch 67606 was successfully built and tested.

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-25 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review205286 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-25 Thread Till Toenshoff
> On June 18, 2018, 9:17 a.m., Benjamin Bannier wrote: > > 3rdparty/cmake/Findlibevent.cmake > > Lines 1 (patched) > > > > > > This file should be called `3rdparty/cmake/FindLIBEVENT.cmake` (package > > name all

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/ --- (Updated June 25, 2018, 2:01 p.m.) Review request for mesos, Andrew

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204911 --- Fix it, then Ship it! Thanks for this Till, LGTM. I mention

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204909 --- Patch looks great! Reviews applied: [67606] Passed command:

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-17 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204908 --- PASS: Mesos patch 67606 was successfully built and tested.

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-17 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/ --- (Updated June 17, 2018, 8:33 p.m.) Review request for mesos, Andrew

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204888 --- Patch looks great! Reviews applied: [67606] Passed command:

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-15 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204885 --- Fix it, then Ship it! Seems reasonable. Going forward, we

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204818 --- PASS: Mesos patch 67606 was successfully built and tested.

Review Request 67606: Allow for unbundled libevent cmake builds.

2018-06-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.