Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

2018-06-19 Thread Benno Evers
> On June 18, 2018, 8:23 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/Makefile.am > > Lines 96-99 (original), 96-97 (patched) > > > > > > We should probably remove this from CMake too, yeah? > > > > `

Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

2018-06-19 Thread Benjamin Bannier
> On June 18, 2018, 10:23 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/Makefile.am > > Lines 96-99 (original), 96-97 (patched) > > > > > > We should probably remove this from CMake too, yeah? > > > >

Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

2018-06-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/#review204992 --- Fix it, then Ship it! Thanks for the cleanup, Benno! Could you

Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

2018-06-18 Thread Andrew Schwartzmeyer
> On June 18, 2018, 1:23 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/Makefile.am > > Lines 96-99 (original), 96-97 (patched) > > > > > > We should probably remove this from CMake too, yeah? > > > > `

Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

2018-06-18 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/#review204946 --- 3rdparty/stout/Makefile.am Lines 96-99 (original), 96-97 (patched

Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

2018-06-18 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/ --- Review request for mesos. Repository: mesos Description --- The macro PI