Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.

2018-06-25 Thread Stéphane Cottin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67728/#review205347 --- Ship it! Ship It! - Stéphane Cottin On June 25, 2018, 7 p.m.

Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.

2018-06-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67728/#review205340 --- Patch looks great! Reviews applied: [67728] Passed command: expo

Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.

2018-06-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67728/#review205339 --- Ship it! Ship It! - Qian Zhang On June 26, 2018, 3 a.m., Jie

Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.

2018-06-25 Thread Jie Yu
> On June 25, 2018, 7:55 p.m., Stéphane Cottin wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Line 433 (original), 432 (patched) > > > > > > This test makes sense only if the containerID i

Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.

2018-06-25 Thread Stéphane Cottin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67728/#review205314 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp Line

Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.

2018-06-25 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67728/#review205309 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.

2018-06-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67728/ --- Review request for mesos, Qian Zhang and Sagar Patwardhan. Bugs: MESOS-9025