Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/#review206738 --- PASS: Mesos patch 68104 was successfully built and tested. Review

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

> On July 31, 2018, 5:38 a.m., Chun-Hung Hsiao wrote: > > src/tests/api_tests.cpp > > Lines 7002-7004 (original), 7002-7021 (patched) > > > > > > How about the following: > > ``` > > slave::Flags slaveFlags

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/ --- (Updated Aug. 1, 2018, 10:18 a.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/#review206684 --- Ship it! src/slave/http.cpp Lines 1831-1833 (patched)

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

> On July 31, 2018, 3:38 a.m., Chun-Hung Hsiao wrote: > > src/slave/http.cpp > > Lines 1821-1822 (patched) > > > > > > The following can be fit into 80 characters: > > ``` > > [this, acceptType](cons

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/#review206651 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/ --- (Updated July 31, 2018, 12:19 p.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

> On July 31, 2018, 5:38 a.m., Chun-Hung Hsiao wrote: > > src/slave/http.cpp > > Lines 1818 (patched) > > > > > > Conventionally we only indent this by 4 extra spaces aligning with > > "return". Good catch, I file

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/#review206637 --- src/slave/http.cpp Lines 1818 (patched)