Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

2018-09-06 Thread Greg Mann
> On Aug. 6, 2018, 9:49 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 759-768 (original), 757-759 (patched) > > > > > > Probably an explanation to the reader is warranted on

Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

2018-09-06 Thread Greg Mann
> On Aug. 6, 2018, 9:49 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 759-768 (original), 757-759 (patched) > > > > > > Probably an explanation to the reader is warranted on

Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

2018-08-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68134/#review206913 --- Fix it, then Ship it! Much appreciated Greg! Looks like there

Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

2018-08-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68134/#review206765 --- Bad review! Reviews applied: [68134, 68048, 67823, 67187]

Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

2018-07-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68134/#review206713 --- PASS: Mesos patch 68134 was successfully built and tested.

Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

2018-07-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68134/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Bugs: MESOS-9124