Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208558 --- Fix it, then Ship it!

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208261 --- Ship it! Ship It! - Qian Zhang On Aug. 31, 2018, 7:48 p.m.,

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208222 --- Patch looks great! Reviews applied: [68230, 68231, 68232]

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/ --- (Updated Aug. 31, 2018, 11:48 a.m.) Review request for mesos, Alexander

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208136 --- PASS: Mesos patch 68232 was successfully built and tested.

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/ --- (Updated Aug. 30, 2018, 3:46 p.m.) Review request for mesos, Alexander

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

> On Aug. 29, 2018, 10:24 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 1710 (patched) > > > > > > Here we set the `promise` in the `readLoop`'s `onAny` callback, but > >

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

> On Aug. 30, 2018, 12:24 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Line 1704 (original), 1704 (patched) > > > > > > Does it have to be `Owned`? If yes and you need

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208127 --- src/slave/containerizer/mesos/io/switchboard.cpp Line 1704

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208085 --- src/slave/containerizer/mesos/io/switchboard.cpp Lines 1033

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review207937 --- Patch looks great! Reviews applied: [68230, 68231, 68232]

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review207936 --- PASS: Mesos patch 68232 was successfully built and tested.