Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-21 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/ --- (Updated Aug. 21, 2018, 6:45 a.m.) Review request for mesos, Alexander

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/#review207649 --- Fix it, then Ship it! src/master/http.cpp Line 2861

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-20 Thread Benno Evers
> On Aug. 20, 2018, 9:51 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 3031 (original), 3035-3036 (patched) > > > > > > These will become `const &`. Huh, weird, this looks like another

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/ --- (Updated Aug. 20, 2018, 2:11 p.m.) Review request for mesos, Alexander

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/#review207606 --- Fix it, then Ship it! src/master/http.cpp Line 3031

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-17 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/#review207533 --- Ship it! Looks like a clean approach, thanks! - Benjamin

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-17 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/ --- (Updated Aug. 17, 2018, 7:04 p.m.) Review request for mesos, Alexander

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/#review207409 --- src/master/http.cpp Line 3032 (original), 3033 (patched)

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/ --- (Updated Aug. 14, 2018, 2:20 p.m.) Review request for mesos, Alexander