Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review209080 --- Ship it! Ship It! - Chun-Hung Hsiao On Sept. 27, 2018, 6:02

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

> On Sept. 26, 2018, 11:16 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 609-610 (original), 627-628 (patched) > > > > > > This message can be displayed by the

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/ --- (Updated Sept. 27, 2018, 6:02 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review209057 --- Fix it, then Ship it!

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/ --- (Updated Sept. 24, 2018, 4:58 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

> On Sept. 20, 2018, 12:59 a.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 347-348 (patched) > > > > > > Are we checking this in case multiple volumes have the same

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

> On Sept. 20, 2018, 12:59 a.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > > Lines 83 (patched) > > > > > > Nit: `const`? Fixed. > On Sept. 20, 2018, 12:59 a.m., Ilya Pronin

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review208778 --- src/slave/containerizer/mesos/isolators/xfs/disk.hpp Lines 83

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

> On Aug. 24, 2018, 11:38 p.m., Chun-Hung Hsiao wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > > Lines 94 (patched) > > > > > > I was wondering if a `hashmap` or a > > `vector` (with a path field

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/ --- (Updated Sept. 10, 2018, 9:34 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

> On Aug. 24, 2018, 11:38 p.m., Chun-Hung Hsiao wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > > Lines 94 (patched) > > > > > > I was wondering if a `hashmap` or a > > `vector` (with a path field

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review207915 --- Still not finished reviewing yet.

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/ --- (Updated Aug. 24, 2018, 11:26 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review207822 --- Only half way through this patch. Will continue tomorrow.

Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/ --- Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and