Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

2018-11-20 Thread Chun-Hung Hsiao
> On Nov. 20, 2018, 3:47 p.m., Benjamin Bannier wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 795-797 (original), 795-798 (patched) > > > > > > Nit: old indent was fine IMO. Dropping this and

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

2018-11-20 Thread Chun-Hung Hsiao
> On Nov. 20, 2018, 3:47 p.m., Benjamin Bannier wrote: > > Could you update the commit message? > > > > I am not sure we need to update all the tests you touched here, but there > > also seems nothing wrong with it. Maybe something to potentially elaborate > > on in the commit message as

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

2018-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69357/#review210719 --- Fix it, then Ship it! Could you update the commit message? I

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

2018-11-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69357/ --- (Updated Nov. 19, 2018, 9:09 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

2018-11-19 Thread Chun-Hung Hsiao
> On Nov. 16, 2018, 12:01 p.m., Benjamin Bannier wrote: > > Can you make sure that this patch does not produce any failing tests (might > > be triggered by earlier patch)? Done for most patches, except for r/69360 and r/69361. - Chun-Hung

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

2018-11-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69357/#review210603 --- Can you make sure that this patch does not produce any failing

Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

2018-11-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69357/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht. Bugs: