Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/#review210747 --- Ship it! Ship It! - Benjamin Bannier On Nov. 19, 2018,

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/ --- (Updated Nov. 19, 2018, 9:12 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-19 Thread Chun-Hung Hsiao
> On Nov. 16, 2018, 12:02 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 3899 (original), 3895 (patched) > > > > > > Before dereferencing `begin` we should

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/#review210604 --- Please move these test fixes to the patches causing the failures

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/#review210588 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/ --- Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.