Re: Review Request 69409: Added Seccomp parser tests.

2019-01-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/#review212315 --- Ship it! Ship It! - Gilbert Song On Nov. 20, 2018, 4:21

Re: Review Request 69409: Added Seccomp parser tests.

2019-01-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/#review212215 --- Ship it! Ship It! - Qian Zhang On Nov. 20, 2018, 8:21 p.m.,

Re: Review Request 69409: Added Seccomp parser tests.

2019-01-22 Thread Qian Zhang
> On Dec. 28, 2018, 9:39 a.m., Qian Zhang wrote: > > src/tests/containerizer/linux_seccomp_parser_tests.cpp > > Lines 359 (patched) > > > > > > Just a question, where do we check the name of the syscall? It seems >

Re: Review Request 69409: Added Seccomp parser tests.

2019-01-03 Thread Andrei Budnik
> On Dec. 28, 2018, 1:39 a.m., Qian Zhang wrote: > > src/tests/containerizer/linux_seccomp_parser_tests.cpp > > Lines 92 (patched) > > > > > > We should check this field in the code below as well? Nope. Filtering by

Re: Review Request 69409: Added Seccomp parser tests.

2018-12-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/#review211561 --- src/tests/containerizer/linux_seccomp_parser_tests.cpp Lines

Re: Review Request 69409: Added Seccomp parser tests.

2018-11-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/#review210709 --- FAIL: Failed to apply the dependent review: 67844. Failed

Review Request 69409: Added Seccomp parser tests.

2018-11-20 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/ --- Review request for mesos, Gilbert Song, James Peach, and Qian Zhang. Bugs: