Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/ --- (Updated Nov. 28, 2018, 6:13 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-28 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/#review210931 --- Ship it! Ship It! - Benjamin Mahler On Nov. 28, 2018, 12:40

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/#review210928 --- src/master/master.hpp Line 2609 (original), 2621 (patched)

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/ --- (Updated Nov. 28, 2018, 12:40 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/#review210914 --- src/master/master.hpp Lines 2594-2609 (original), 2596-2619 (patc

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/ --- (Updated Nov. 27, 2018, 11:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-27 Thread Chun-Hung Hsiao
> On Nov. 27, 2018, 9:02 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Line 2599 (original), 2600-2604 (patched) > > > > > > Hm.. based on this comment, should we only be sending in the > > disconnecte

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/#review210904 --- Thanks for jumping on this and producing a fix! Some small edit su

Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-26 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and T