Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211825 --- PASS: Mesos patch 69662 was successfully built and tested. Review

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

> On Jan. 9, 2019, 11:19 p.m., Chun-Hung Hsiao wrote: > > src/webui/app/controllers.js > > Lines 697 (patched) > > > > > > Instead of setting `agent.resource_providers` with > > `state.resource_providers` and mutati

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/ --- (Updated Jan. 10, 2019, 10:19 a.m.) Review request for mesos, Armand Grillet, B

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211802 --- Fix it, then Ship it! It looks like a great start. Thanks for a

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211799 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211779 --- Fix it, then Ship it! src/webui/app/controllers.js Lines 714-7

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/ --- (Updated Jan. 7, 2019, 11:33 p.m.) Review request for mesos, Armand Grillet, Be

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

> On Jan. 7, 2019, 10:52 p.m., Benjamin Mahler wrote: > > Hm.. it looks like the rows are bigger in this table? (I measured in the > > screenshot and it appears to be the case). is it missing some attributes > > that the reservation table has? Very good catch, thanks! There was a typo in one o

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211741 --- Hm.. it looks like the rows are bigger in this table? (I measured

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

> On Jan. 7, 2019, 7:14 p.m., Benjamin Mahler wrote: > > src/webui/app/agents/agent.html > > Lines 176-179 (patched) > > > > > > Is this hidden if there are no providers? Can you show a screenshot of > > the entire

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211732 --- On Jan. 7, 2019, 10:02 p.m., Benjamin Bannier wrote:

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/ --- (Updated Jan. 7, 2019, 10:02 p.m.) Review request for mesos, Armand Grillet, Be

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211732 --- src/webui/app/agents/agent.html Lines 176-179 (patched)

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/ --- (Updated Jan. 4, 2019, 11:14 a.m.) Review request for mesos, Armand Grillet, Be

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211658 --- Can you attach a screenshot of the web UI here? - Chun-Hung Hsiao

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211637 --- Ship it! LGTM. The button logic is similar to what is in `agent

Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/ --- Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.