Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/ --- (Updated Feb. 5, 2019, 9:27 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Klaus Ma
> On Feb. 5, 2019, 12:31 a.m., Klaus Ma wrote: > > Ship It! LGTM overall, but I don-t have enough experience right now to review the detail, please wait for BenM's comments :) - Klaus --- This is an automatically generated e-mail. To

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212539 --- Ship it! Ship It! - Klaus Ma On Feb. 4, 2019, 8:29 p.m.,

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212530 --- PASS: Mesos patch 69885 was successfully built and tested.

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212525 --- Ship it! src/tests/resources_tests.cpp Lines 3892 (patched)

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Benjamin Bannier
> On Feb. 4, 2019, 7:22 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp > > Lines 3883-3887 (original), 3883-3891 (patched) > > > > > > I love the spirit of this change, but this seems pretty

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/ --- (Updated Feb. 4, 2019, 9:29 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212519 --- src/tests/resources_tests.cpp Lines 3883-3887 (original),

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212518 --- PASS: Mesos patch 69885 was successfully built and tested.

Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Bugs: MESOS-8835