Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review214185 --- Ship it! Ship It! - Greg Mann On March 27, 2019, 4:41 p.m.,

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review214125 --- Bad review! Reviews applied: [70117, 70116, 70156, 70115] Error:

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review214118 --- FAIL: Failed to apply the dependent review: 70116. Failed command

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

> On March 15, 2019, 12:01 a.m., Greg Mann wrote: > > Could you also update a test to verify that metrics transition correctly? > > i.e., that operation metrics will start at `pending == 0` and `finished == > > 0`, then transition to `pending == 1` and `finished == 0`, then finally to > > `pen

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/ --- (Updated March 27, 2019, 4:41 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review214062 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213986 --- PASS: Mesos patch 70117 was successfully built and tested. Review

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213985 --- Patch looks great! Reviews applied: [70115, 70156, 70185, 70116,

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213732 --- Could you also update a test to verify that metrics transition cor

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213685 --- Patch looks great! Reviews applied: [70115, 70156, 70185, 70116,

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213673 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

> On March 13, 2019, 12:29 a.m., Joseph Wu wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3832-3845 (original), 3833-3846 (patched) > > > > > > In cases like this, it would be more appropri

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/ --- (Updated March 13, 2019, 4:01 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/ --- (Updated March 13, 2019, 3:51 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213641 --- src/tests/storage_local_resource_provider_tests.cpp Lines 3832-38

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/ --- (Updated March 11, 2019, 7:15 p.m.) Review request for mesos, Gastón Kleiman, G