Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-26 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70214/ --- (Updated March 27, 2019, 5:56 a.m.) Review request for mesos, Benjamin

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-25 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70214/ --- (Updated March 26, 2019, 5:06 a.m.) Review request for mesos, Benjamin

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70214/#review213975 --- Ship it! - Benjamin Bannier On March 22, 2019, 7:12 a.m.,

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-25 Thread Benjamin Bannier
> On March 19, 2019, 3:57 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.hpp > > Lines 100 (patched) > > > > > > Does it make sense to move this into the process? It would lead to > > simpler dispatch

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-22 Thread Chun-Hung Hsiao
> On March 19, 2019, 2:57 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.hpp > > Lines 100 (patched) > > > > > > Does it make sense to move this into the process? It would lead to > > simpler dispatch

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-22 Thread Benjamin Bannier
> On March 19, 2019, 3:57 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.hpp > > Lines 100 (patched) > > > > > > Does it make sense to move this into the process? It would lead to > > simpler dispatch

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70214/ --- (Updated March 22, 2019, 6:12 a.m.) Review request for mesos, Benjamin

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-20 Thread Chun-Hung Hsiao
> On March 19, 2019, 2:57 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.hpp > > Lines 100 (patched) > > > > > > Does it make sense to move this into the process? It would lead to > > simpler dispatch

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70214/#review213804 --- This review does seem to do exactly what

Review Request 70214: Added skeleton code for v0 `VolumeManager`.

2019-03-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70214/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: