Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70225/ --- (Updated April 2, 2019, 5:54 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

> On March 28, 2019, 9:23 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 4139 (original), 4139 (patched) > > > > > > Do you think it would make sense to put the value

Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70225/#review214165 --- Ship it! src/tests/storage_local_resource_provider_tests.cpp L

Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70225/ --- (Updated March 28, 2019, 8 a.m.) Review request for mesos, Benjamin Bannier, Ja

Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70225/#review214087 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70225/#review213770 --- Patch looks great! Reviews applied: [70168, 70169, 70213, 70214,

Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70225/#review213769 --- PASS: Mesos patch 70225 was successfully built and tested. Review

Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70225/#review213762 --- Patch looks great! Reviews applied: [70168, 70169, 70213, 70214,

Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70225/#review213760 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70225/ --- Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schl