Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review214018 --- Ship it! Ship It! - Joseph Wu On March 22, 2019, 7:35 p.m.,

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213944 --- PASS: Mesos patch 70244 was successfully built and tested.

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213943 --- Patch looks great! Reviews applied: [70264, 70242, 70243, 70244]

Re: Review Request 70244: Added new operation reconciliation tests.

> On March 21, 2019, 11:39 p.m., Joseph Wu wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 1706-1707 (patched) > > > > > > I'm not seeing a clear race in the test body. > > > > The

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/ --- (Updated March 23, 2019, 2:35 a.m.) Review request for mesos, Benjamin

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213934 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213932 --- Patch looks great! Reviews applied: [70264, 70242, 70243, 70244]

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213898 --- Patch looks great! Reviews applied: [70264, 70242, 70243, 70244]

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213894 --- +1 on the first test. Some questions on the second one.

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213895 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213872 --- Patch looks great! Reviews applied: [70200, 70208, 70221, 70242,

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213870 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213854 --- Patch looks great! Reviews applied: [70200, 70208, 70221, 70242,

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213852 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70244: Added new operation reconciliation tests.

> On March 20, 2019, 7:14 p.m., Greg Mann wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 1894 (patched) > > > > > > Whoops, I intended this to be `OPERATION_FINISHED`. There seems to be > > an

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/ --- (Updated March 20, 2019, 7:47 p.m.) Review request for mesos, Benjamin

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213845 --- src/tests/operation_reconciliation_tests.cpp Lines 1894

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213821 --- Patch looks great! Reviews applied: [70200, 70208, 70221, 70242,

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213817 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman,