Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/ --- (Updated March 29, 2019, 1:52 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review214109 --- src/examples/operation_feedback_framework.cpp Lines 16 (patched)

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review214080 --- Ship it! Ship It! - Greg Mann On March 26, 2019, 4:57 p.m.,

Re: Review Request 70282: Added new example framework for operation feedback.

> On March 25, 2019, 8:24 p.m., Greg Mann wrote: > > src/examples/operation_feedback_framework.cpp > > Lines 61-103 (patched) > > > > > > Should we just enclose everything outside of `main()` in the > > `mesos::v1`

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review214061 --- Patch looks great! Reviews applied: [70281, 70282] Passed

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review214060 --- PASS: Mesos patch 70282 was successfully built and tested.

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/ --- (Updated March 26, 2019, 4:57 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review214002 --- Patch looks great! Reviews applied: [70281, 70282] Passed

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review213987 --- Thanks Benno, this looks great!! Some comments below, but the

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review213990 --- PASS: Mesos patch 70282 was successfully built and tested.

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/ --- (Updated March 25, 2019, 1:50 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review213929 --- Patch looks great! Reviews applied: [70281, 70282] Passed

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review213924 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/ --- Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.