Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.

2019-04-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70320/#review214242 --- Ship it! Ship It! - Benjamin Mahler On March 29, 2019, 11:22

Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.

2019-03-29 Thread Meng Zhu
> On March 27, 2019, 7:41 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1928 (patched) > > > > > > Rather than adding this additional function, can't `shrinkResoures` > > ta

Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.

2019-03-29 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70320/ --- (Updated March 29, 2019, 4:22 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.

2019-03-28 Thread Benjamin Mahler
> On March 27, 2019, 2:41 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1928 (patched) > > > > > > Rather than adding this additional function, can't `shrinkResoures` > > ta

Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.

2019-03-28 Thread Benjamin Mahler
> On March 27, 2019, 2:41 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1928 (patched) > > > > > > Rather than adding this additional function, can't `shrinkResoures` > > ta

Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.

2019-03-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70320/#review214152 --- Patch looks great! Reviews applied: [70318, 70319, 70320] Passed

Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.

2019-03-27 Thread Meng Zhu
> On March 27, 2019, 7:41 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1928 (patched) > > > > > > Rather than adding this additional function, can't `shrinkResoures` > > ta