Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/ --- (Updated May 6, 2019, 10:04 p.m.) Review request for mesos, Alexander

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215075 --- Ship it! Ship It! - Chun-Hung Hsiao On May 6, 2019, 10:04

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/ --- (Updated May 6, 2019, 10:02 p.m.) Review request for mesos, Alexander

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215074 --- Fix it, then Ship it! Thanks for making this test more

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215070 --- Patch looks great! Reviews applied: [70594, 70595] Passed

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/ --- (Updated May 6, 2019, 6:34 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Benjamin Mahler
> On May 3, 2019, 11:31 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Lines 2092-2108 (patched) > > > > > > I tried this unit test w/o the fix in the following settings: > >

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Chun-Hung Hsiao
> On May 3, 2019, 11:31 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Lines 2092-2108 (patched) > > > > > > I tried this unit test w/o the fix in the following settings: > >

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Alexander Rukletsov
> On May 3, 2019, 11:31 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Lines 2092-2108 (patched) > > > > > > I tried this unit test w/o the fix in the following settings: > >

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215050 --- Patch looks great! Reviews applied: [70594, 70595] Passed

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215035 --- 3rdparty/libprocess/src/tests/process_tests.cpp Lines 2086

Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/ --- Review request for mesos, Alexander Rukletsov and Chun-Hung Hsiao. Bugs: