Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Benno Evers
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > > Lines 530-533 (patched) > > > > > > Does it mean that hostname validation with the help

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Benno Evers
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 565-567 (patched) > > > > > > Hm, this is unfortunate. I wonder if we can use > > https://www.openssl.org/d

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Benno Evers
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 565-567 (patched) > > > > > > Hm, this is unfortunate. I wonder if we can use > > https://www.openssl.org/d

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Alexander Rukletsov
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > > Lines 530-533 (patched) > > > > > > Does it mean that hostname validation with the help

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Benno Evers
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > > Lines 530-533 (patched) > > > > > > Does it mean that hostname validation with the help

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/#review215673 --- 3rdparty/libprocess/src/openssl.cpp Lines 142 (patched)

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-05-31 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/ --- (Updated May 31, 2019, 3:47 p.m.) Review request for mesos and Alexander Ruklet

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-05-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/#review215578 --- Patch looks great! Reviews applied: [70747, 70748, 70749] Passed

Review Request 70749: WIP: Use openssl hostname validation.

2019-05-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti