Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-24 Thread Benjamin Mahler
> On July 23, 2019, 9:35 p.m., Benjamin Mahler wrote: > > src/python/native_common/common.hpp > > Lines 155-159 (patched) > > > > > > Is this still needed? Looks like a declaration of the definition above? > > Andre

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-24 Thread Andrei Sekretenko
> On July 23, 2019, 9:35 p.m., Benjamin Mahler wrote: > > src/python/native_common/common.hpp > > Lines 155-159 (patched) > > > > > > Is this still needed? Looks like a declaration of the definition above? No, this

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-24 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71082/ --- (Updated July 24, 2019, 1:34 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71082/#review216818 --- Fix it, then Ship it! Looks good, I only held off on committing

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-23 Thread Andrei Sekretenko
> On July 18, 2019, 5:59 p.m., Benjamin Mahler wrote: > > Looks like I will wait until the egg issue is fixed I haven't managed to find a **simple**, portable and non-racy way to simultaneously build two python eggs which need the same source. Gave up and moved that template specialization int

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-23 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71082/ --- (Updated July 23, 2019, 4:13 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-18 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71082/#review216739 --- Looks like I will wait until the egg issue is fixed src/python/n

Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-17 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71082/#review216697 --- src/python/native_common/ext_modules.py.in Lines 125 (patched)

Review Request 71082: Added a helper to create std::vector from iterable into python bindings.

2019-07-16 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71082/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9864 ht