Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-20 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217884 --- Ship it! Ship It! - Till Toenshoff On Sept. 19, 2019, 2:35

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217865 --- Patch looks great! Reviews applied: [71496, 71497] Passed

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/ --- (Updated Sept. 19, 2019, 2:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217834 --- Patch looks great! Reviews applied: [71496, 71497] Passed

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-18 Thread Benno Evers
> On Sept. 17, 2019, 5:39 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 118 (patched) > > > > > > can you use the `alias` argument in `add()` for these? Actually, after having

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-18 Thread Benno Evers
> On Sept. 17, 2019, 5:39 p.m., Vinod Kone wrote: > > docs/ssl.md > > Lines 100 (patched) > > > > > > These deprecations need to be documented in CHANGELOG and upgrades.md. I updated `upgrades.md`, but I think the

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-18 Thread Benno Evers
> On Sept. 18, 2019, 9:50 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 545-547 (patched) > > > > > > We are stating that there would be a deprecation; does that mean at > > some

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-18 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/ --- (Updated Sept. 18, 2019, 12:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-18 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217787 --- 3rdparty/libprocess/src/openssl.cpp Lines 545-547 (patched)

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217792 --- drive by review. 3rdparty/libprocess/src/openssl.cpp Lines 118

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217786 --- Patch looks great! Reviews applied: [71496, 71497] Passed

Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-17 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/ --- Review request for mesos, Greg Mann and Till Toenshoff. Repository: mesos