Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/#review218460 --- Fix it, then Ship it!

Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/#review218432 --- Patch looks great! Reviews applied: [71639] Passed command:

Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

> On Oct. 24, 2019, 7:21 a.m., Andrei Sekretenko wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 8414 (patched) > > > > > > Wouldn't the order of parameters look more intuitive if it were > >

Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/ --- (Updated Oct. 28, 2019, 8:43 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/#review218386 --- Many thanks for this benchmark! Even in its WIP version it

Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/#review218383 --- Bad patch! Reviews applied: [71639] Failed command: ['bash',

Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/ --- (Updated Oct. 23, 2019, 7:56 p.m.) Review request for mesos, Andrei Sekretenko