Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218484 --- Patch looks great! Reviews applied: [71641] Passed command: expo

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

> On Oct. 30, 2019, 11:38 p.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 11128 (patched) > > > > > > Looks like the compiler is complaining about a type mismatch here. Yikes, I am in shock my comp

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/ --- (Updated Nov. 1, 2019, 1:08 p.m.) Review request for mesos, Benno Evers, Benjam

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218466 --- Fix it, then Ship it! src/master/master.cpp Lines 7847 (patche

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218459 --- Bad patch! Reviews applied: [71641] Failed command: ['bash', '-c

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/ --- (Updated Oct. 30, 2019, 1:27 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

> On Oct. 28, 2019, 6:07 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 7848 (patched) > > > > > > Hm.. don't we enforce agent removal by not allowing the agent to > > re-register? > > > >

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218442 --- src/master/master.cpp Lines 7848 (patched)

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

> On Oct. 28, 2019, 6:07 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 7848 (patched) > > > > > > Hm.. don't we enforce agent removal by not allowing the agent to > > re-register? > > > >

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218430 --- Patch looks great! Reviews applied: [71641] Passed command: expo

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

> On Oct. 28, 2019, 7:07 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 7848 (patched) > > > > > > Hm.. don't we enforce agent removal by not allowing the agent to > > re-register? > > > >

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218426 --- Bad patch! Reviews applied: [71641] Failed command: ['bash', '-c

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218422 --- src/master/master.cpp Lines 7848 (patched)

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/ --- (Updated Oct. 28, 2019, 6:53 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

> On Oct. 22, 2019, 1:41 a.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 7847-7848 (patched) > > > > > > This seems to warrant an explanation? Seems very non-obvious how this > > situation can happ

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218316 --- src/master/master.cpp Lines 7847-7848 (patched)

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218308 --- Bad patch! Reviews applied: [71641] Failed command: ['bash', '-c

Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/ --- Review request for mesos, Benno Evers, Benjamin Mahler, and Greg Mann. Bugs: ME