Re: Review Request 71734: Revamped attribute handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71734/ --- (Updated Nov. 7, 2019, 2:23 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 71734: Revamped attribute handling in stout.

> On Nov. 6, 2019, 5:03 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Line 65 (original), 65 (patched) > > > > > > nit: single line? > > Benno Evers wrote: > I thought about it, but

Re: Review Request 71734: Revamped attribute handling in stout.

> On Nov. 6, 2019, 5:03 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/attributes.hpp > > Lines 17 (patched) > > > > > > Did you want to export this macro? I am not sure it would be useful > >

Re: Review Request 71734: Revamped attribute handling in stout.

> On Nov. 6, 2019, 4:03 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/attributes.hpp > > Lines 17 (patched) > > > > > > Did you want to export this macro? I am not sure it would be useful > >

Re: Review Request 71734: Revamped attribute handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71734/#review218544 --- Fix it, then Ship it!

Re: Review Request 71734: Revamped attribute handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71734/ --- (Updated Nov. 6, 2019, 3:56 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 71734: Revamped attribute handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71734/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Greg Mann.