Re: Review Request 71805: Fixed memory leak in openssl verification function.

2019-11-22 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/ --- (Updated Nov. 22, 2019, 10:53 p.m.) Review request for mesos, Benjamin

Re: Review Request 71805: Fixed memory leak in openssl verification function.

2019-11-22 Thread Benjamin Mahler
> On Nov. 22, 2019, 5:33 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Line 843 (original), 843 (patched) > > > > > > This says "if this call succeeds", but I guess it should say in all >

Re: Review Request 71805: Fixed memory leak in openssl verification function.

2019-11-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/#review218777 --- Ship it! Ship It! - Greg Mann On Nov. 22, 2019, 4:20 p.m.,

Re: Review Request 71805: Fixed memory leak in openssl verification function.

2019-11-22 Thread Benno Evers
> On Nov. 22, 2019, 5:33 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Line 843 (original), 843 (patched) > > > > > > This says "if this call succeeds", but I guess it should say in all >

Re: Review Request 71805: Fixed memory leak in openssl verification function.

2019-11-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/#review218765 --- Ship it! Good find! Can you file a MESOS ticket for this with

Re: Review Request 71805: Fixed memory leak in openssl verification function.

2019-11-22 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/#review218763 --- 3rdparty/libprocess/src/openssl.cpp Line 866 (original), 866

Review Request 71805: Fixed memory leak in openssl verification function.

2019-11-22 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/ --- Review request for mesos, Benjamin Bannier and Greg Mann. Repository: mesos