Re: Review Request 71824: Updated stout recordio encoder/decoder to be lower-level.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71824/#review21 --- Ship it! Ship It! - Andrei Sekretenko On Dec. 3, 2019, 5:25

Re: Review Request 71824: Updated stout recordio encoder/decoder to be lower-level.

2019-12-02 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71824/ --- (Updated Dec. 3, 2019, 5:25 a.m.) Review request for mesos, Andrei Sekretenko a

Re: Review Request 71824: Updated stout recordio encoder/decoder to be lower-level.

2019-12-02 Thread Benjamin Mahler
> On Dec. 2, 2019, 12:49 p.m., Andrei Sekretenko wrote: > > 3rdparty/stout/include/stout/recordio.hpp > > Line 82 (original) > > > > > > Now that Encoder has no state, did you consider dropping `class > > Encoder` al

Re: Review Request 71824: Updated stout recordio encoder/decoder to be lower-level.

2019-12-02 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71824/#review218876 --- 3rdparty/stout/include/stout/recordio.hpp Line 82 (original)

Review Request 71824: Updated stout recordio encoder/decoder to be lower-level.

2019-11-26 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71824/ --- Review request for mesos, Andrei Sekretenko and Greg Mann. Bugs: MESOS-10026