Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71859/#review219135 --- Ship it! Made the adjustment below, and will commit shortly!

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

> On Dec. 4, 2019, 6:21 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 3736-3741 (original), 3743-3751 (patched) > > > > > > Hm.. can you reply to this comment with an example of the logging > >

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

> On Dec. 4, 2019, 6:43 p.m., Benjamin Mahler wrote: > > src/master/authorization.cpp > > Lines 38 (patched) > > > > > > Actually, come to think of it, this construction style seems quite odd? > > > > We're

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

> On Dec. 4, 2019, 6:59 p.m., Benjamin Mahler wrote: > > Another observation from a subsequent review with: > > > > ``` > > static std::vector growVolume( > > const Offer::Operation::GrowVolume& grow); > > > > static std::vector shrinkVolume( > > const

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

> On Dec. 4, 2019, 6:21 p.m., Benjamin Mahler wrote: > > src/master/authorization.cpp > > Lines 41-42 (patched) > > > > > > We try in new code to stick to the following assignment style, since it > > works

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71859/ --- (Updated Jan. 2, 2020, 8 p.m.) Review request for mesos, Benjamin Bannier and

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71859/#review218918 --- Another observation from a subsequent review with: ``` static

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71859/#review218916 --- Sorry, one more thing that I originally missed in this one and

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71859/#review218914 --- I'm really excited to see the synchronous authorization

Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71859/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs: