Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

2020-01-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/#review219207 --- Ship it! Ship It! - Benjamin Bannier On Jan. 10, 2020, 2:37

Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

2020-01-10 Thread Benjamin Bannier
> On Jan. 6, 2020, 1:59 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/address.hpp > > Line 232 (original), 247 (patched) > > > > > > For unnamed sockets we would now return an empty string

Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

2020-01-09 Thread Benno Evers
> On Jan. 6, 2020, 12:59 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/address.hpp > > Lines 238 (patched) > > > > > > As discussed offline, let's add a `CHECK` here that `sun_path` is not >

Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

2020-01-09 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/ --- (Updated Jan. 10, 2020, 1:37 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

2020-01-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/#review219127 --- 3rdparty/libprocess/include/process/address.hpp Lines 224

Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

2020-01-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/#review219118 --- Patch looks great! Reviews applied: [71947] Passed command:

Review Request 71947: Handled embedded null bytes in abstract domain socket names.

2020-01-02 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Repository: