Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-03-10 Thread Greg Mann
> On March 5, 2020, 3:56 p.m., Greg Mann wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Lines 489-496 (patched) > > > > > > Does it make sense to put this part in either the 'MemoryForward' or > >

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-03-10 Thread Qian Zhang
> On March 5, 2020, 11:56 p.m., Greg Mann wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Lines 474 (patched) > > > > > > Instead of using `path::join()`, is there a cgroup helper function we > > c

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-03-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/#review219798 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 474 (pat

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/#review219247 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 380 (pat

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-01-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/ --- (Updated Jan. 15, 2020, 10:24 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-01-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/ --- (Updated Jan. 7, 2020, 11:05 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-01-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/#review219126 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884, 7

Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-01-05 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10047 ht