Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219922 --- Ship it! Ship It! - Qian Zhang On Feb. 12, 2020, 11:47 p.m.,

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219914 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

> On Янв. 13, 2020, 6:53 д.п., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 315 (patched) > > > > > > Shouldn't it be a warning instead? > > Andrei Budnik wrote: >

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/ --- (Updated Фев. 12, 2020, 3:47 п.п.) Review request for mesos, Greg Mann and Qian

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219329 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884, 7

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219327 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884, 7

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

> On Янв. 13, 2020, 6:53 д.п., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 315 (patched) > > > > > > Shouldn't it be a warning instead? I copied it from the Linux Laun

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219275 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884, 7

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219236 --- Patch looks great! Reviews applied: [71855, 71931, 71856, 71858,

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219229 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219196 --- Patch looks great! Reviews applied: [71855, 71931, 71856, 71858,

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219155 --- Bad review! Reviews applied: [71966, 71965] Error: 2020-01-07 20

Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/ --- Review request for mesos, Greg Mann and Qian Zhang. Bugs: MESOS-10079 https