Re: Review Request 71971: Added special case to stout's handling of C++ attributes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71971/#review219180 --- Patch looks great! Reviews applied: [71971] Passed command:

Re: Review Request 71971: Added special case to stout's handling of C++ attributes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71971/ --- (Updated Jan. 8, 2020, 4 p.m.) Review request for mesos and Benjamin Bannier.

Re: Review Request 71971: Added special case to stout's handling of C++ attributes.

> On Jan. 8, 2020, 2:28 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/attributes.hpp > > Lines 52 (patched) > > > > > > This makes `STOUT_DEPRECATED` a noop on all current clang versions. We > >

Re: Review Request 71971: Added special case to stout's handling of C++ attributes.

> On Jan. 8, 2020, 1:28 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/attributes.hpp > > Lines 52 (patched) > > > > > > This makes `STOUT_DEPRECATED` a noop on all current clang versions. We > >

Re: Review Request 71971: Added special case to stout's handling of C++ attributes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71971/#review219174 --- Fix it, then Ship it!

Review Request 71971: Added special case to stout's handling of C++ attributes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71971/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description