Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 6, 2020, 12:24 a.m.) Review request for mesos, Andrei Sekretenko a

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/#review220641 --- Ship it! Ship It! - Andrei Sekretenko On May 5, 2020, 5:52 p

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

> On May 5, 2020, 12:27 p.m., Andrei Sekretenko wrote: > > src/tests/slave_tests.cpp > > Lines 12227-12228 (patched) > > > > > > I 'm not sure if these assertions add any value: these properties of V1 > > API are

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 5, 2020, 5:52 p.m.) Review request for mesos, Andrei Sekretenko an

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 5, 2020, 5:51 p.m.) Review request for mesos, Andrei Sekretenko an

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/#review220634 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 12227-12

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 5, 2020, 5:22 a.m.) Review request for mesos, Andrei Sekretenko an

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 5, 2020, 5:10 a.m.) Review request for mesos, Andrei Sekretenko an

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/#review220377 --- Fix it, then Ship it! src/slave/slave.cpp Lines 1077 (patched)

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/#review220354 --- Bad patch! Reviews applied: [72368] Failed command: ['bash', '-c

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated April 17, 2020, 6:04 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

> On April 17, 2020, 3:40 p.m., Andrei Sekretenko wrote: > > Btw, why did you mark this patch as depending on > > https://reviews.apache.org/r/72364/ ? > > > > I would say this is the other way round: after this one is committed, I'll > > be able to properly use the offer in the test in r7236

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated April 17, 2020, 6:03 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/#review220348 --- Ship it! Btw, why did you mark this patch as depending on http

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/#review220326 --- Bad patch! Reviews applied: [72363, 72364, 72368] Failed command

Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: MESOS-10