Re: Review Request 74981: [cgroups2] allow enable() to take in a set instead of string

2024-05-20 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74981/#review226471 --- Fix it, then Ship it! "take in a set instead of string" -> look

Re: Review Request 74981: [cgroups2] allow enable() to take in a set instead of string

2024-05-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74981/#review226464 --- Bad patch! Reviews applied: [74981] Failed command: ['bash', '-c

Re: Review Request 74981: [cgroups2] allow enable() to take in a set instead of string

2024-05-17 Thread Jason Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74981/ --- (Updated May 17, 2024, 9:46 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 74981: [cgroups2] allow enable() to take in a set instead of string

2024-05-17 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74981/#review226462 --- Ship it! just some minor nits below src/slave/containerizer/m

Review Request 74981: [cgroups2] allow enable() to take in a set instead of string

2024-05-17 Thread Jason Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74981/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -