Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3564#issuecomment-66741908
[Test build #24398 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24398/consoleFull)
for PR 3564 at commit
[`9a22bd4`](https://githu
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2939
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3683#issuecomment-66740852
[Test build #24397 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24397/consoleFull)
for PR 3683 at commit
[`f36cfb4`](https://githu
GitHub user WangTaoTheTonic opened a pull request:
https://github.com/apache/spark/pull/3683
[Deploy]some other processes might take the pid
Some other processes might use the pid saved in pid file. In that case we
should ignore it and launch daemons.
JIRA is down for maint
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3564#issuecomment-66740134
[Test build #24395 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24395/consoleFull)
for PR 3564 at commit
[`f6bd3ed`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3564#issuecomment-66740137
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3431#issuecomment-66739973
[Test build #24396 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24396/consoleFull)
for PR 3431 at commit
[`6f1259c`](https://githu
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/3571#issuecomment-66739820
@vanzin I'm going to finish it very soon; will you be available to help me
with those failing tests?
---
If your project is set up for it, you can reply to thi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3564#issuecomment-66739133
[Test build #24395 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24395/consoleFull)
for PR 3564 at commit
[`f6bd3ed`](https://githu
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/3564#issuecomment-66739082
Yeah, I'm ignoring the problem of interleaved output for now since I'm
hitting two more critical problems first: 1) the tests aren't running
successfully, or 2) the test
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3676
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3676#issuecomment-66738629
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3602
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3673
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3673#issuecomment-66738298
Thanks for the fast fix! Merged to master and 1.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3445
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3675#issuecomment-66738175
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3563
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3563#issuecomment-66738098
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3418#issuecomment-66737964
[Test build #24394 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24394/consoleFull)
for PR 3418 at commit
[`20155cd`](https://githu
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3470#issuecomment-66737945
[Test build #24393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24393/consoleFull)
for PR 3470 at commit
[`8f4f585`](https://githu
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3499#issuecomment-66737908
thanks, merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3522
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3522#issuecomment-66737835
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3572#issuecomment-66737774
Thanks, merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3602#issuecomment-66737651
LGTM, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/3418#issuecomment-66736611
Yes, it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66735868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66735865
[Test build #24392 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24392/consoleFull)
for PR 3607 at commit
[`f6bee0e`](https://gith
Github user dikejiang commented on the pull request:
https://github.com/apache/spark/pull/3583#issuecomment-66735373
@mengxr OK to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3395#issuecomment-66734604
LGTM except for styling issues, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729377
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Y
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-66733745
[Test build #24391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24391/consoleFull)
for PR 1222 at commit
[`216c5a3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-66733748
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729186
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Y
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66733569
Did a double check and spotted a few more minor styling issues. This PR
should be ready to go once those issue are fixed. Thanks!
---
If your project is set up for it,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-66733539
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-66733536
[Test build #24390 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24390/consoleFull)
for PR 1222 at commit
[`dce28e9`](https://gith
Github user judynash commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729137
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Yo
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729067
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -140,7 +160,8 @@ class HiveThrift
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729057
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -121,15 +128,28 @@ class HiveThri
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729040
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -70,11 +70,17 @@ class HiveThrift
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21729017
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -85,10 +86,22 @@ private[hive] class H
Github user tianyi commented on the pull request:
https://github.com/apache/spark/pull/3375#issuecomment-66733251
@marmbrus would you mind review this PR again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21728999
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Y
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21728960
--- Diff: docs/sql-programming-guide.md ---
@@ -938,6 +938,18 @@ Configuration of Hive is done by placing your
`hive-site.xml` file in `conf/`.
Y
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3395#discussion_r21728943
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -80,8 +80,11 @@ class JoinSuite extends QueryTest with
BeforeAndAfterEach {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3395#discussion_r21728940
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -80,8 +80,11 @@ class JoinSuite extends QueryTest with
BeforeAndAfterEach {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66731837
[Test build #24392 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24392/consoleFull)
for PR 3607 at commit
[`f6bee0e`](https://githu
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66731518
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66731361
[Test build #24389 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24389/consoleFull)
for PR 3672 at commit
[`2e9c11c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66731363
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3682#issuecomment-66730770
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user jmschrack opened a pull request:
https://github.com/apache/spark/pull/3682
Added "--package" argument to make-distribution.sh
"--package" creates a distribution without building.
Added the above info to the README.md.
You can merge this pull request into a Git repos
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-66729812
[Test build #24391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24391/consoleFull)
for PR 1222 at commit
[`216c5a3`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-66729615
[Test build #24390 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24390/consoleFull)
for PR 1222 at commit
[`dce28e9`](https://githu
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r21727765
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -217,37 +234,92 @@ private[history] class FsHistoryProvider(conf:
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66729130
When we submit an application using spark-submit, the `spark.driver.memory`
in properties file will be got by `driverMemory` in
`SparkSubmitArguments.scala`.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3676#issuecomment-66728650
Ah cool, couldn't open JIRA this morning to check whether it's a known
issue :)
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66728596
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66728592
[Test build #24388 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24388/consoleFull)
for PR 3607 at commit
[`f6bee0e`](https://gith
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r21727233
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -58,43 +61,79 @@ private[spark] class EventLoggingListener(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3681#issuecomment-66728262
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3681#issuecomment-66728261
**[Test build #24384 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24384/consoleFull)**
for PR 3681 at commit
[`d832c5b`](https://git
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r21727246
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -58,36 +61,78 @@ private[spark] class EventLoggingListener(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-66728229
[Test build #24387 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24387/consoleFull)
for PR 1222 at commit
[`f91c13e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-66728231
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r21727188
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -217,37 +234,92 @@ private[history] class FsHistoryProvider(co
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r21727037
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -217,37 +234,92 @@ private[history] class FsHistoryProvider(co
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3409#issuecomment-66727444
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3409#issuecomment-66727442
[Test build #24386 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24386/consoleFull)
for PR 3409 at commit
[`5a505d3`](https://gith
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r21726971
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -217,37 +234,92 @@ private[history] class FsHistoryProvider(co
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66727025
I see, so in cluster mode the AM memory reads from `--driver-memory`, but
is `512MB` otherwise. What about `spark.driver.memory`? Do we need respect that
anywhere?
-
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3395#discussion_r21726677
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -80,8 +80,11 @@ class JoinSuite extends QueryTest with
BeforeAndAfterEach {
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3563#issuecomment-66726455
LGTM, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user judynash commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66726073
I have addressed the feedbacks (thank you Cheng!) and added documentation.
Let me know if there is anything else. Thanks again!
---
If your project is set up for it, yo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66726018
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66726017
[Test build #24385 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24385/consoleFull)
for PR 3672 at commit
[`2b1d312`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3672#issuecomment-66725464
[Test build #24389 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24389/consoleFull)
for PR 3672 at commit
[`2e9c11c`](https://githu
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3676#issuecomment-66724763
Thanks for such detailed review! I checked your query with hive-0.14.0, the
bug no longer exists.
---
If your project is set up for it, you can reply to this email a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66724634
[Test build #24388 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24388/consoleFull)
for PR 3607 at commit
[`f6bee0e`](https://githu
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-66724192
@andrewor14
Ehh...You mean the `javaOpts += "-Xmx" + args.amMemory + "m"` in
`ClientBase.scala`?
If you mean so, the args is an ClientArguments object wh
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3636#issuecomment-66723145
@Lewuathe Sorry---one more request. Could you actually use
"convergenceTol" instead of "convergenceTolerance" in order to fit with the
public API in LBFGS? Thanks!
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-66722914
[Test build #24387 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24387/consoleFull)
for PR 1222 at commit
[`f91c13e`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3409#issuecomment-66722004
[Test build #24386 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24386/consoleFull)
for PR 3409 at commit
[`5a505d3`](https://githu
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3418#issuecomment-66721992
Are `UCASE` and `LCASE` standard SQL operators? If yes then this LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3418#discussion_r21724949
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -289,6 +291,8 @@ class SqlParser extends AbstractSparkSQLParser {
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3636#issuecomment-66721864
@Lewuathe Thanks for the updates! I just added a few last comments (which
should be the last).
---
If your project is set up for it, you can reply to this email and h
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3636#discussion_r21724908
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala
---
@@ -138,6 +138,45 @@ class GradientDescentSuite extends F
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3636#discussion_r21724912
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -77,6 +80,14 @@ class GradientDescent private[mllib] (priva
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3636#discussion_r21724909
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala
---
@@ -138,6 +138,45 @@ class GradientDescentSuite extends F
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3636#discussion_r21724910
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -182,34 +203,46 @@ object GradientDescent extends Logging {
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3675#issuecomment-66721742
LGTM, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3409#issuecomment-66721562
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
1 - 100 of 294 matches
Mail list logo
