Github user helena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3798#discussion_r22649516
--- Diff:
external/kafka/src/main/scala/org/apache/spark/rdd/kafka/KafkaCluster.scala ---
@@ -0,0 +1,313 @@
+/*
+ * Licensed to the Apache Software Fou
Github user SaintBacchus closed the pull request at:
https://github.com/apache/spark/pull/3885
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22648851
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
Github user helena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3798#discussion_r22648712
--- Diff:
external/kafka/src/main/scala/org/apache/spark/rdd/kafka/KafkaRDD.scala ---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3827#issuecomment-69172458
Sorry for the late response. This LGTM except a minor styling issue. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3827#discussion_r22648661
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -195,4 +196,19 @@ class SQLQuerySuite extends QueryTest {
Github user prabeesh commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69172360
@srowen made it as local variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69172074
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69172065
[Test build #25222 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25222/consoleFull)
for PR 3947 at commit
[`0cc5e46`](https://gith
Github user helena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3798#discussion_r22648458
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DeterministicKafkaInputDStream.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3557#issuecomment-69171546
[Test build #25224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25224/consoleFull)
for PR 3557 at commit
[`bee9447`](https://githu
Github user helena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3798#discussion_r22648091
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DeterministicKafkaInputDStream.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69170705
[Test build #25223 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25223/consoleFull)
for PR 3947 at commit
[`fc6abd5`](https://githu
Github user helena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3798#discussion_r22647904
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DeterministicKafkaInputDStream.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed t
Github user helena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3798#discussion_r22647846
--- Diff:
external/kafka/src/main/scala/org/apache/spark/rdd/kafka/KafkaRDD.scala ---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user helena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3798#discussion_r22647698
--- Diff: external/kafka/pom.xml ---
@@ -44,7 +44,7 @@
org.apache.kafka
kafka_${scala.binary.version}
- 0.8.0
--- E
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/3931#issuecomment-69170077
can you add a test case for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/3944#issuecomment-69169473
Aactually i do not think we should make ```CaseInsensitiveMap```
serializable since it only used to pass parameters in driver
---
If your project is set up for it, you can
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3949#issuecomment-69169469
[Test build #25221 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25221/consoleFull)
for PR 3949 at commit
[`3f57fd2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3949#issuecomment-69169475
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user wangxiaojing commented on the pull request:
https://github.com/apache/spark/pull/2765#issuecomment-69169225
@tdas Thanks a lot . I fix them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user OopsOutOfMemory commented on the pull request:
https://github.com/apache/spark/pull/3946#issuecomment-69169210
@tianyi
I suggest to move the `plan info`(see below) into `Statement Cell` as a
`+detail top-tip` or `options` whatever you like. The `Detail cell` use to
di
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/3945#issuecomment-69169100
Are merge conflicts the reason, that Travis is not running?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/3945#issuecomment-69168603
@srowen I've fixed that up and pushed it. Any more comments?
(I removed the line for RowMatrix, since it is tested just below)
---
If your project is set up for it,
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22646991
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
---
@@ -0,0 +1,179 @@
+/*
+ *
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3948#issuecomment-69168267
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3948#issuecomment-69168261
[Test build #25220 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25220/consoleFull)
for PR 3948 at commit
[`6b48e64`](https://gith
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22646869
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
+ *
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/3900#issuecomment-69167088
@aarondav Thank you for pointing out.
So all `spark.storage.memoryMapThreshold` default values should be 2MB,
right?
---
If your project is set up for it, you can
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22646500
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
+ *
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/3933#issuecomment-69166579
@mengxr I think it is difficult to infer what the order of precision and
recall is returned from `pr` method name. So I think keeping the order of
returned values on met
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69166176
@prabeesh my question about `/tmp` was why it is not a local variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user huitseeker commented on a diff in the pull request:
https://github.com/apache/spark/pull/3798#discussion_r22646185
--- Diff: external/kafka/pom.xml ---
@@ -44,7 +44,7 @@
org.apache.kafka
kafka_${scala.binary.version}
- 0.8.0
-
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69165585
[Test build #25222 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25222/consoleFull)
for PR 3947 at commit
[`0cc5e46`](https://githu
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22645935
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed t
Github user prabeesh commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69165253
- the hard code '\tmp' may be creating garbage. so created temp directory
using internal methods and deleting after the use.
- revert to _
- added the finally blo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3948#issuecomment-69163952
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3948#issuecomment-69163949
[Test build #25218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25218/consoleFull)
for PR 3948 at commit
[`2c62e9d`](https://gith
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22645139
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed t
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22645081
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed t
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3936#discussion_r22644880
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -437,6 +437,9 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
* Not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3949#issuecomment-69162577
[Test build #25221 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25221/consoleFull)
for PR 3949 at commit
[`3f57fd2`](https://githu
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/3949
Add BLAS.dsyr and use it in GaussianMixtureEM
This pr uses BLAS.dsyr to replace few implementations in GaussianMixtureEM.
You can merge this pull request into a Git repository by running:
$ git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3935#issuecomment-69162366
[Test build #25216 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25216/consoleFull)
for PR 3935 at commit
[`fbe6f6d`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3935#issuecomment-69162373
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22644599
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3571#issuecomment-69162117
[Test build #25215 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25215/consoleFull)
for PR 3571 at commit
[`937d839`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3571#issuecomment-69162123
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3948#issuecomment-69161493
[Test build #25220 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25220/consoleFull)
for PR 3948 at commit
[`6b48e64`](https://githu
Github user tianyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22644087
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -121,7 +152,16 @@ class HiveThriftSe
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3946#issuecomment-69160716
@tianyi I understand that because Hive 0.13.1 made incompatible changes to
`SessionManager.openSession`, and you'd like to avoid adding new stuff to the
shim layer. How
Github user yanbohappy commented on the pull request:
https://github.com/apache/spark/pull/3827#issuecomment-69160371
Can anyone verify and merge this patch? It's a bug appeared frequently and
fix it asap will be better.
---
If your project is set up for it, you can reply to this ema
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3820#issuecomment-69160063
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3820#issuecomment-69160056
[Test build #25211 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25211/consoleFull)
for PR 3820 at commit
[`8526a33`](https://gith
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22643566
--- Diff:
sql/hive-thriftserver/v0.12.0/src/main/scala/org/apache/spark/sql/hive/thriftserver/Shim12.scala
---
@@ -184,8 +184,10 @@ private[hive] class Spa
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3926#issuecomment-69159164
[Test build #25212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25212/consoleFull)
for PR 3926 at commit
[`dd0e60a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3926#issuecomment-69159170
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3805#issuecomment-69159092
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3805#issuecomment-69159079
[Test build #25213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25213/consoleFull)
for PR 3805 at commit
[`6339ca7`](https://gith
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22643431
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3946#issuecomment-69158921
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3946#issuecomment-69158918
[Test build #25219 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25219/consoleFull)
for PR 3946 at commit
[`f796a81`](https://gith
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22643414
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerTab.scala
---
@@ -0,0 +1,45 @@
+/*
+ * License
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3946#issuecomment-69158816
[Test build #25219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25219/consoleFull)
for PR 3946 at commit
[`f796a81`](https://githu
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22643358
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
---
@@ -50,6 +51,7 @@ private[hive] clas
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69158640
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69158629
[Test build #25214 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25214/consoleFull)
for PR 3947 at commit
[`5786340`](https://gith
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22643277
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -28,6 +28,7 @@ import org.apache.spark
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3945#discussion_r22643219
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrix.scala
---
@@ -102,6 +102,9 @@ class IndexedRowMatrix(
k:
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3946#issuecomment-69158309
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22643231
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -70,6 +73,34 @@ class HiveThriftS
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22642963
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -379,4 +421,33 @@ class HiveThrif
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22642887
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -121,7 +152,16 @@ class HiveThrif
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69157174
I'm not sure about most of these.
- Why is tempDir a field?
- _ is more idiomatic in Scala than null for a reference field's default
value.
- Why remove th
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22642871
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -70,6 +73,34 @@ class HiveThriftS
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3948#issuecomment-69156592
[Test build #25218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25218/consoleFull)
for PR 3948 at commit
[`2c62e9d`](https://githu
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22642634
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22642514
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22642469
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -70,6 +73,34 @@ class HiveThriftS
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3948#issuecomment-69155894
[Test build #25217 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25217/consoleFull)
for PR 3948 at commit
[`6677766`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3948#issuecomment-69155898
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3861#issuecomment-69155646
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3861#issuecomment-69155640
[Test build #25209 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25209/consoleFull)
for PR 3861 at commit
[`f39cdd2`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3948#issuecomment-69155549
[Test build #25217 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25217/consoleFull)
for PR 3948 at commit
[`6677766`](https://githu
GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/3948
[SPARK-4861][SQL] Refactory command in spark sql
Follow up for #3712.
This PR finally remove ```CommandStrategy``` and make all commands follow
```RunnableCommand``` so they can go with ```case r:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3935#issuecomment-69155022
[Test build #25216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25216/consoleFull)
for PR 3935 at commit
[`fbe6f6d`](https://githu
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22641884
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -121,7 +152,16 @@ class HiveThrif
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/3935#discussion_r22641890
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -328,18 +328,19 @@ class SQLContext(@transient val sparkContext:
SparkC
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3571#issuecomment-69154552
[Test build #25215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25215/consoleFull)
for PR 3571 at commit
[`937d839`](https://githu
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22641470
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22641447
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2906#discussion_r22641414
--- Diff:
mllib/src/test/java/org/apache/spark/mllib/clustering/JavaHierarchicalClusteringSuite.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apac
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2906#discussion_r22641364
--- Diff:
mllib/src/test/java/org/apache/spark/mllib/clustering/JavaHierarchicalClusteringSuite.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apac
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22641251
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2906#discussion_r22641250
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaHierarchicalClustering.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache S
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22641245
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2906#discussion_r22641223
--- Diff: docs/mllib-clustering.md ---
@@ -154,6 +156,175 @@ section of the Spark
Quick Start guide. Be sure to also include *spark-mllib* to your build
f
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22641236
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69152996
[Test build #25214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25214/consoleFull)
for PR 3947 at commit
[`5786340`](https://githu
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3946#discussion_r22641201
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerUIEventListener.scala
---
@@ -0,0 +1,182 @@
+/*
601 - 700 of 740 matches
Mail list logo
