[GitHub] spark pull request: [SPARK-4553] [SPARK-5767] [SQL] Wires Parquet ...

2015-02-15 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/4563#issuecomment-74471070 Removed the `withSQLConf` trick in test suites like `ParquetQuerySuite`. A simplified version of the problem can be shown as: ```scala withSQLConf(SQLConf.P

[GitHub] spark pull request: [SPARK-4553] [SPARK-5767] [SQL] Wires Parquet ...

2015-02-15 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/4563#issuecomment-74470473 Many thanks to @yhuai, who helped getting rid of a bug in those Parquet test suites which disable Parquet data source and fall back to the old implementation! --- If

[GitHub] spark pull request: [SPARK-4553] [SPARK-5767] [SQL] Wires Parquet ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4563#issuecomment-74470211 [Test build #27544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27544/consoleFull) for PR 4563 at commit [`fa98d27`](https://githu

[GitHub] spark pull request: [SPARK-3570] Include time to open files in shu...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4550#issuecomment-74468166 [Test build #27543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27543/consoleFull) for PR 4550 at commit [`ea3a4ae`](https://githu

[GitHub] spark pull request: [SPARK-5831][Streaming]When checkpoint file si...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4621#issuecomment-74466488 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SQL] [Minor] Update the SpecificMutableRow.co...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4619#issuecomment-74466533 [Test build #27542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27542/consoleFull) for PR 4619 at commit [`9300d23`](https://gith

[GitHub] spark pull request: [SQL] [Minor] Update the SpecificMutableRow.co...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4619#issuecomment-74466538 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5831][Streaming]When checkpoint file si...

2015-02-15 Thread XuTingjun
GitHub user XuTingjun opened a pull request: https://github.com/apache/spark/pull/4621 [SPARK-5831][Streaming]When checkpoint file size is bigger than 10, then delete the old ones You can merge this pull request into a Git repository by running: $ git pull https://github.com/

[GitHub] spark pull request: [SPARK-5830][Core]Don't create unnecessary dir...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4620#issuecomment-74465847 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-5830][Core]Don't create unnecessary dir...

2015-02-15 Thread Sephiroth-Lin
GitHub user Sephiroth-Lin opened a pull request: https://github.com/apache/spark/pull/4620 [SPARK-5830][Core]Don't create unnecessary directory for local root dir Now will create an unnecessary directory for local root directory, and this directory will not be deleted after applicat

[GitHub] spark pull request: [Ml] SPARK-5804 Explicitly manage cache in Cro...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4595#issuecomment-74465158 [Test build #27541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27541/consoleFull) for PR 4595 at commit [`66a7cfb`](https://gith

[GitHub] spark pull request: [Ml] SPARK-5804 Explicitly manage cache in Cro...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4595#issuecomment-74465163 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: Bug fix for SPARK-5242: "ec2/spark_ec2.py lauc...

2015-02-15 Thread voukka
Github user voukka commented on the pull request: https://github.com/apache/spark/pull/4038#issuecomment-74464588 @shivaram that's good point to store selected address type. @srowen I think it requires a bit more testing. Hopefully I'll get some time for that today --- If your pr

[GitHub] spark pull request: [SQL] Optimize arithmetic and predicate operat...

2015-02-15 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/4472#issuecomment-74463234 @kai-zeng The code LGTM, and I've tested the `Add` in an aggregation benchmark, it shows about 20% performance improved. So can you rebase the code? --- If your

[GitHub] spark pull request: [SQL] [Minor] Update the SpecificMutableRow.co...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4619#issuecomment-74462045 [Test build #27542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27542/consoleFull) for PR 4619 at commit [`9300d23`](https://githu

[GitHub] spark pull request: [SQL] [Minor] Update the SpecificMutableRow.co...

2015-02-15 Thread chenghao-intel
GitHub user chenghao-intel opened a pull request: https://github.com/apache/spark/pull/4619 [SQL] [Minor] Update the SpecificMutableRow.copy When profiling the Join / Aggregate queries, I noticed lots of `MutableValue` objects created via VisualVM, as the `SpecificMutableRow` are m

[GitHub] spark pull request: [SPARK-5722][SQL] fix for infer long type in p...

2015-02-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/4521#issuecomment-74461832 @dondrake I just noticed it is for branch 1.2. Do we have a patch for the master? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2015-02-15 Thread lianhuiwang
Github user lianhuiwang commented on the pull request: https://github.com/apache/spark/pull/3173#issuecomment-74461781 @justinuang i think you are interesting in SPARK-5763. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-5641] [EC2] Allow spark_ec2.py to copy ...

2015-02-15 Thread florianverhein
Github user florianverhein commented on the pull request: https://github.com/apache/spark/pull/4583#issuecomment-74461651 Cool, thanks @shivaram. I've been using it to deploy rpms and jars :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4618#issuecomment-74461557 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4618#issuecomment-74461554 [Test build #27540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27540/consoleFull) for PR 4618 at commit [`94bacac`](https://gith

[GitHub] spark pull request: [Ml] SPARK-5804 Explicitly manage cache in Cro...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4595#issuecomment-74460814 [Test build #27541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27541/consoleFull) for PR 4595 at commit [`66a7cfb`](https://githu

[GitHub] spark pull request: [Ml] SPARK-5804 Explicitly manage cache in Cro...

2015-02-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4595#issuecomment-74460620 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [Ml] SPARK-5796 Don't transform data on a last...

2015-02-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4590#issuecomment-74459734 Merged into master and branch-1.3. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Ml] SPARK-5796 Don't transform data on a last...

2015-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5799][SQL] Compute aggregation function...

2015-02-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4592#discussion_r24731797 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala --- @@ -39,13 +39,14 @@ class GroupedData protected[sql](df: DataFrameImpl, groupingExpr

[GitHub] spark pull request: [SPARK-5799][SQL] Compute aggregation function...

2015-02-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4592#discussion_r24731788 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala --- @@ -39,13 +39,14 @@ class GroupedData protected[sql](df: DataFrameImpl, groupingExpr

[GitHub] spark pull request: [SPARK-5799][SQL] Compute aggregation function...

2015-02-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4592#discussion_r24731783 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala --- @@ -39,13 +39,14 @@ class GroupedData protected[sql](df: DataFrameImpl, groupingExpr

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4618#issuecomment-74459497 [Test build #27540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27540/consoleFull) for PR 4618 at commit [`94bacac`](https://githu

[GitHub] spark pull request: SPARK-5815 [MLLIB] Deprecate SVDPlusPlus APIs ...

2015-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4614 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-5815 [MLLIB] Deprecate SVDPlusPlus APIs ...

2015-02-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4614#issuecomment-74459251 LGTM. Merged into master and branch-1.3. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-5769] Set params in constructors and in...

2015-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5769] Set params in constructors and in...

2015-02-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4564#issuecomment-74458711 Merged into master and branch-1.3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4618#issuecomment-74458624 [Test build #27539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27539/consoleFull) for PR 4618 at commit [`d71ed09`](https://gith

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4618#issuecomment-74458630 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4618#issuecomment-74456655 [Test build #27539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27539/consoleFull) for PR 4618 at commit [`d71ed09`](https://githu

[GitHub] spark pull request: [SPARK-5770] forbid user to overwrite jar usin...

2015-02-15 Thread XuTingjun
Github user XuTingjun closed the pull request at: https://github.com/apache/spark/pull/4565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4618#issuecomment-74454541 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4618#issuecomment-74454536 [Test build #27538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27538/consoleFull) for PR 4618 at commit [`a4a6ec3`](https://gith

[GitHub] spark pull request: [SPARK-5641] [EC2] Allow spark_ec2.py to copy ...

2015-02-15 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/4583#issuecomment-74453770 Thanks @florianverhein -- Code change looks good to me -- I'd like to test this out on a cluster launch to verify it though. Will try to get to it tomorrow. --- If you

[GitHub] spark pull request: [SPARK-5825] [Spark Submit] Remove the double ...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4611#issuecomment-74453783 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5825] [Spark Submit] Remove the double ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4611#issuecomment-74453780 [Test build #27537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27537/consoleFull) for PR 4611 at commit [`0b9ea52`](https://gith

[GitHub] spark pull request: SPARK-5548: Fixed a race condition in AkkaUtil...

2015-02-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4343#issuecomment-74453703 Yep, looks like it's still here: https://amplab.cs.berkeley.edu/jenkins/view/Spark/job/Spark-1.3-SBT/AMPLAB_JENKINS_BUILD_PROFILE=hadoop1.0,label=centos/93/testReport/ju

[GitHub] spark pull request: [SPARK-5641] [EC2] Allow spark_ec2.py to copy ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4583#issuecomment-74452762 [Test build #27536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27536/consoleFull) for PR 4583 at commit [`7b8e3d8`](https://gith

[GitHub] spark pull request: [SPARK-5641] [EC2] Allow spark_ec2.py to copy ...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4583#issuecomment-74452766 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5746][SQL] Check invalid cases for the ...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4617#issuecomment-74452655 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5746][SQL] Check invalid cases for the ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4617#issuecomment-74452654 [Test build #27535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27535/consoleFull) for PR 4617 at commit [`f30bdad`](https://gith

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4618#issuecomment-74452611 [Test build #27538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27538/consoleFull) for PR 4618 at commit [`a4a6ec3`](https://githu

[GitHub] spark pull request: [SPARK-4865][SQL]Include temporary tables in S...

2015-02-15 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/4618 [SPARK-4865][SQL]Include temporary tables in SHOW TABLES This PR adds a `ShowTablesCommand` to support `SHOW TABLES [IN databaseName]` SQL command. The result of `SHOW TABLE` has two columns, `tableN

[GitHub] spark pull request: [SPARK-5722][SQL] fix for infer long type in p...

2015-02-15 Thread dondrake
Github user dondrake commented on the pull request: https://github.com/apache/spark/pull/4521#issuecomment-74450385 So, in ./sql/core/src/main/scala/org/apache/spark/sql/execution/pythonUdfs.scala In EvaluatePython.toJava() I added the following: ``` case (_, LongT

[GitHub] spark pull request: [SPARK-2313] Use socket to communicate Gateway...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4603#issuecomment-74449873 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-2313] Use socket to communicate Gateway...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4603#issuecomment-74449870 [Test build #27533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27533/consoleFull) for PR 4603 at commit [`6a7740b`](https://gith

[GitHub] spark pull request: [SPARK-5825] [Spark Submit] Remove the double ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4611#issuecomment-74449523 [Test build #27537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27537/consoleFull) for PR 4611 at commit [`0b9ea52`](https://githu

[GitHub] spark pull request: [SPARK-5825] [Spark Submit] Remove the double ...

2015-02-15 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/4611#issuecomment-74449462 Thank you @srowen for the explanation, I've updated the scripts, can you review it again? --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: [SPARK-5826][Streaming] Fix Configuration not ...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4612#issuecomment-74448845 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5826][Streaming] Fix Configuration not ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4612#issuecomment-74448841 [Test build #27532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27532/consoleFull) for PR 4612 at commit [`7ec71db`](https://gith

[GitHub] spark pull request: [SPARK-5641] [EC2] Allow spark_ec2.py to copy ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4583#issuecomment-74448214 [Test build #27536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27536/consoleFull) for PR 4583 at commit [`7b8e3d8`](https://githu

[GitHub] spark pull request: [SPARK-5746][SQL] Check invalid cases for the ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4617#issuecomment-74448216 [Test build #27535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27535/consoleFull) for PR 4617 at commit [`f30bdad`](https://githu

[GitHub] spark pull request: [SPARK-5746][SQL] Check invalid cases for the ...

2015-02-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4617#discussion_r24728499 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetQuerySuite.scala --- @@ -37,20 +37,22 @@ class ParquetQuerySuite extends QueryTest with P

[GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...

2015-02-15 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/2851#issuecomment-74447987 working on this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-5746][SQL] Check invalid cases for the ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4617#issuecomment-74447199 [Test build #27534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27534/consoleFull) for PR 4617 at commit [`99da57e`](https://gith

[GitHub] spark pull request: [SPARK-5746][SQL] Check invalid cases for the ...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4617#issuecomment-74447200 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5746][SQL] Check invalid cases for the ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4617#issuecomment-74446691 [Test build #27534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27534/consoleFull) for PR 4617 at commit [`99da57e`](https://githu

[GitHub] spark pull request: [SPARK-5746][SQL] Check invalid cases for the ...

2015-02-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4617#discussion_r24728239 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -66,14 +66,17 @@ class HiveContext(sc: SparkContext) extends SQLContext(sc

[GitHub] spark pull request: [SPARK-5746][SQL] Check invalid cases for the ...

2015-02-15 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/4617 [SPARK-5746][SQL] Check invalid cases for the write path of data source API JIRA: https://issues.apache.org/jira/browse/SPARK-5746 @liancheng @marmbrus You can merge this pull request into a

[GitHub] spark pull request: [SPARK-2313] Use socket to communicate Gateway...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4603#issuecomment-74446042 [Test build #27533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27533/consoleFull) for PR 4603 at commit [`6a7740b`](https://githu

[GitHub] spark pull request: [SPARK-5826][Streaming] Fix Configuration not ...

2015-02-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4612#discussion_r24728085 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala --- @@ -74,10 +74,12 @@ class FileInputDStream[K, V, F <: NewInpu

[GitHub] spark pull request: [SPARK-2313] Use socket to communicate Gateway...

2015-02-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4603#issuecomment-74445894 I've updated this based on the review feedback; see the individual commits for a summary of the changes. --- If your project is set up for it, you can reply to this em

[GitHub] spark pull request: [SPARK-2313] Use socket to communicate Gateway...

2015-02-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4603#discussion_r24728054 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonGatewayServer.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-5826][Streaming] Fix Configuration not ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4612#issuecomment-74445204 [Test build #27532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27532/consoleFull) for PR 4612 at commit [`7ec71db`](https://githu

[GitHub] spark pull request: [SPARK-5826][Streaming] Fix Configuration not ...

2015-02-15 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/4612#discussion_r24727846 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala --- @@ -74,10 +74,12 @@ class FileInputDStream[K, V, F <: NewI

[GitHub] spark pull request: [SPARK-5090][examples] The improvement of pyth...

2015-02-15 Thread GenTang
Github user GenTang commented on a diff in the pull request: https://github.com/apache/spark/pull/3920#discussion_r24727321 --- Diff: examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala --- @@ -18,20 +18,34 @@ package org.apache.spark.exam

[GitHub] spark pull request: [SPARK-5769] Set params in constructors and in...

2015-02-15 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/4564#issuecomment-74441686 LGTM, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-5697] Configurable registration retry i...

2015-02-15 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/4481#issuecomment-74439444 Just increase it depending on the environment. Of course the user should exercise discretion - if the retry count needs to be very high there's likely something very wron

[GitHub] spark pull request: SPARK-4682 [CORE] Consolidate various 'Clock' ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4514#issuecomment-74439003 [Test build #27531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27531/consoleFull) for PR 4514 at commit [`b5e53df`](https://gith

[GitHub] spark pull request: SPARK-4682 [CORE] Consolidate various 'Clock' ...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4514#issuecomment-74439013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: SPARK-4682 [CORE] Consolidate various 'Clock' ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4514#issuecomment-74435114 [Test build #27531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27531/consoleFull) for PR 4514 at commit [`b5e53df`](https://githu

[GitHub] spark pull request: SPARK-4682 [CORE] Consolidate various 'Clock' ...

2015-02-15 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4514#issuecomment-74434987 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: SPARK-4682 [CORE] Consolidate various 'Clock' ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4514#issuecomment-74432145 **[Test build #27527 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27527/consoleFull)** for PR 4514 at commit [`b5e53df`](https://git

[GitHub] spark pull request: SPARK-4682 [CORE] Consolidate various 'Clock' ...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4514#issuecomment-74432148 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5769] Set params in constructors and in...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4564#issuecomment-74432107 [Test build #27530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27530/consoleFull) for PR 4564 at commit [`fedf720`](https://gith

[GitHub] spark pull request: [SPARK-5769] Set params in constructors and in...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4564#issuecomment-74432111 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: SPARK-5815 [MLLIB] Deprecate SVDPlusPlus APIs ...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4614#issuecomment-74430603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: SPARK-5815 [MLLIB] Deprecate SVDPlusPlus APIs ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4614#issuecomment-74430600 [Test build #27528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27528/consoleFull) for PR 4614 at commit [`288cb05`](https://gith

[GitHub] spark pull request: [SPARK-5778] throw if nonexistent metrics conf...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4571#issuecomment-74430516 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5778] throw if nonexistent metrics conf...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4571#issuecomment-74430513 [Test build #27529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27529/consoleFull) for PR 4571 at commit [`5bccb14`](https://gith

[GitHub] spark pull request: [Minor] [SQL] Renames stringRddToDataFrame to ...

2015-02-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/4613#issuecomment-74429989 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark pull request: [SPARK-5769] Set params in constructors and in...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4564#issuecomment-74428482 [Test build #27530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27530/consoleFull) for PR 4564 at commit [`fedf720`](https://githu

[GitHub] spark pull request: [Ml] SPARK-5804 Explicitly manage cache in Cro...

2015-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4595#issuecomment-74428050 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [Ml] SPARK-5804 Explicitly manage cache in Cro...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4595#issuecomment-74428046 [Test build #27526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27526/consoleFull) for PR 4595 at commit [`66a7cfb`](https://gith

[GitHub] spark pull request: [SPARK-5778] throw if nonexistent metrics conf...

2015-02-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4571#issuecomment-74427338 Overall, looks good to me. I do like the idea of failing here, since otherwise it can be very confusing to people why their settings are not being picked up. To avoid su

[GitHub] spark pull request: [SPARK-5778] throw if nonexistent metrics conf...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4571#issuecomment-74427279 [Test build #27529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27529/consoleFull) for PR 4571 at commit [`5bccb14`](https://githu

[GitHub] spark pull request: [SPARK-4553] [SPARK-5767] [SQL] Wires Parquet ...

2015-02-15 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/4563#issuecomment-74427223 @yhuai @marmbrus All comments have been addressed, have to squash all commits to ease rebasing. Should be good to go. --- If your project is set up for it, you can re

[GitHub] spark pull request: [SPARK-5134] Bump default hadoop.version to 2....

2015-02-15 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3917#issuecomment-74427089 @pwendell To be clear this didn't end up being anything to do with IntelliJ. It's a question of whether building vs Hadoop 1.0.4 or Hadoop 2.x by default is better. I thin

[GitHub] spark pull request: SPARK-5815 [MLLIB] Deprecate SVDPlusPlus APIs ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4614#issuecomment-74427056 [Test build #27528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27528/consoleFull) for PR 4614 at commit [`288cb05`](https://githu

[GitHub] spark pull request: [SPARK-5778] throw if nonexistent metrics conf...

2015-02-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4571#issuecomment-74427064 Jenkins, retest this please. (sorry @ryan-williams we're trying to get tests in better shape). --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark pull request: [SPARK-5783] Better eventlog-parsing error mes...

2015-02-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4573#issuecomment-74427023 Thanks @ryan-williams - this is a useful feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5134] Bump default hadoop.version to 2....

2015-02-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3917#issuecomment-74426982 yeah - sorry to be a wet blanket. Basically my feeling is that we shouldn't optimize for our own convenience as developers in turn for making life more difficult (in a r

[GitHub] spark pull request: SPARK-4682 [CORE] Consolidate various 'Clock' ...

2015-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4514#issuecomment-74426607 [Test build #27527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27527/consoleFull) for PR 4514 at commit [`b5e53df`](https://githu

[GitHub] spark pull request: SPARK-5815 [MLLIB] Deprecate SVDPlusPlus APIs ...

2015-02-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4614#issuecomment-74426536 If that's the direction we are going to take, let's mention the route `run -> runSVDPlusPlus (1.3) -> run (1.4)` in the deprecation message and the doc, and then mark `run

  1   2   3   >